fix(ui): consistent disabled tokens + filter popover UX + input-group height#355
Merged
Conversation
Outer InputGroup measured 74px (Input h-18 + wrapper border) while sibling Buttons measured 72px (h-18 with border-box). This 2px gap was visible in toolbars that placed SearchInput next to a Button (e.g. Filter). Force the outer wrapper to h-18 only when it directly contains an <input>, and stretch InputGroupControl to h-full so the input fits the bordered box. Textarea and contenteditable children keep h-auto so Textarea and RichTextEditor heights aren't clipped.
…gn popover end - Add data-[state=open]:border-ring / ring-ring / ring-[2px] on the Filter trigger so the brand-colored ring stays visible when the popover is open (focus has moved to the content) - Set PopoverContent align="end" so the 600px-wide popover's right edge aligns with the trigger's right edge instead of extending past the toolbar
Add aria-selected and a grey background on the column item that matches selectedColumn so users can see which column's values are currently shown in the right panel.
Compute internalTotalSelected from in-progress options state and pass it as the Reset All button's disabled flag — no point resetting when nothing is selected.
🦋 Changeset detectedLatest commit: 2240d53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why did you create this PR
What did you do
chrome
(Input, Textarea, Select, Switch, RadioGroup, Checkbox, Toggle, Tabs, Slider, Command,
ColorPicker, Calendar)
InputGroupauto-detect a:disableddescendant input/textarea and thearia-disabledattributeso wrappers around RichTextEditor and fieldset-disabled forms render the disabled chrome
correctly
InputGroupwrapping a direct<input>toh-18to match sibling Buttons;previously it
was 74px because the wrapper border stacked on top of the inner Input's
h-18extend past the toolbar
background
@genseki/ui)Screenshots / Recordings
Checklist